[FIX] Allow deletion of own account for passwordless accounts (e.g. OAUTH) #21119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieleiro
previously approved these changes
Apr 20, 2021
sampaiodiego
approved these changes
Apr 21, 2021
sampaiodiego
changed the title
This was referenced Apr 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
For accounts without a local password (OAUTH, SAML etc) it was not possible to delete your own account. The modal asking for the username (as confirmation) didn't return the username but the SHA256-Hash of the username.
Fixed this by comparing the hashes of the username instead of clear-text username. Also removed
isPasswordfrom modal when entering the username.Issue(s)
Closes #19557
Steps to test or reproduce
Further comments